Skip to content

[cudf] Route dictionary encode temp allocations through memory_resources - #23642

Draft
nirandaperera wants to merge 11 commits into
NVIDIA:mainfrom
nirandaperera:dictionary-encode-memory-resources
Draft

[cudf] Route dictionary encode temp allocations through memory_resources#23642
nirandaperera wants to merge 11 commits into
NVIDIA:mainfrom
nirandaperera:dictionary-encode-memory-resources

Conversation

@nirandaperera

@nirandaperera nirandaperera commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

Depends on #23665

A part of #20780.

  • Port dictionary encode / decode (public + detail APIs and implementations) to take cudf::memory_resources, routing output and temporary allocations explicitly.
  • Update dictionary encode/decode tests (and drop stale row-operator TODOs) so they exercise the new resource pair.
  • Duplicate the narrow fixed-width/string gather plumbing needed so encode/decode can pass memory_resources into detail::gather on this base; list/segmented gather production is left on the existing single-ref APIs via output_mr.

Test plan

  • DICTIONARY_TEST --gtest_filter='DictionaryEncode*:DictionaryDecode*'
  • ROW_OPERATOR_TEST --gtest_filter='TypedTableView*:NaNTableView*:RowOperator*'

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@nirandaperera nirandaperera added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 12, 2026
@copy-pr-bot

copy-pr-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 12, 2026
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Signed-off-by: niranda perera <niranda.perera@gmail.com>
Port encode/decode APIs and tests to explicit output/temporary resources,
and duplicate the narrow fixed-width/string gather plumbing required to
pass memory_resources into detail::gather without the list gather slice.
@nirandaperera
nirandaperera force-pushed the dictionary-encode-memory-resources branch from 5280c4f to b292deb Compare August 17, 2026 20:04
@nirandaperera
nirandaperera changed the base branch from main to pull-request/23665 August 17, 2026 21:41
@nirandaperera
nirandaperera changed the base branch from pull-request/23665 to main August 17, 2026 21:43
@nirandaperera
nirandaperera changed the base branch from main to pull-request/23556 August 17, 2026 22:20
@nirandaperera
nirandaperera changed the base branch from pull-request/23556 to pull-request/23665 August 17, 2026 22:20
@nirandaperera nirandaperera changed the title [cudf] Route dictionary encode and gather temps through memory_resources [cudf] Route dictionary encode temp allocations through memory_resources Aug 17, 2026
@nirandaperera
nirandaperera changed the base branch from pull-request/23665 to main August 17, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant